Skip to content

Make local webhook port configurable #748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 8, 2025
Merged

Make local webhook port configurable #748

merged 1 commit into from
Sep 8, 2025

Conversation

@karelyatin
Copy link
Contributor

@karelyatin karelyatin commented Sep 5, 2025

Will be helpful when running multiple operators locally

@openshift-ci openshift-ci bot requested review from jlarriba and paramite September 5, 2025 06:00
@karelyatin
Make local webhook port configurable
c4a0a15 
Will be helpful when running multiple operators locally
@softwarefactory-project-zuul
Copy link

softwarefactory-project-zuul bot commented Sep 5, 2025

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://softwarefactory-project.io/zuul/t/rdoproject.org/buildset/2750c1540be84f61a5e6f1a43e5995ea

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 39m 04s
✔️ podified-multinode-edpm-deployment-crc SUCCESS in 1h 23m 08s
✔️ telemetry-openstack-meta-content-provider-master SUCCESS in 2h 12m 01s
✔️ telemetry-operator-multinode-default-telemetry SUCCESS in 1h 18m 15s
❌ functional-tests-osp18 FAILURE in 1h 53m 51s

@karelyatin
Copy link
Contributor Author

karelyatin commented Sep 5, 2025

Unrelated:-
Sep 05 13:11:35 compute-0 systemd[1]: Starting kepler container...
Sep 05 13:11:35 compute-0 podman[222916]: 2025-09-05 07:41:35.909707727 +0000 UTC m=+0.283979824 container init 7dd46d78c7ad9ddcbce3332334abfed9a8eb6275708a9927df2839fd871bb9da (image=quay.io/sustainable_computing_io/kepler:v0.10.2, name>
Sep 05 13:11:35 compute-0 podman[222916]: 2025-09-05 07:41:35.941797526 +0000 UTC m=+0.316069613 container start 7dd46d78c7ad9ddcbce3332334abfed9a8eb6275708a9927df2839fd871bb9da (image=quay.io/sustainable_computing_io/kepler:v0.10.2, nam>
Sep 05 13:11:35 compute-0 kepler[222933]: kepler: error: unknown short flag '-v', try --help
Sep 05 13:11:35 compute-0 podman[222916]: kepler

@karelyatin
Copy link
Contributor Author

karelyatin commented Sep 5, 2025

Unrelated:- Sep 05 13:11:35 compute-0 systemd[1]: Starting kepler container... Sep 05 13:11:35 compute-0 podman[222916]: 2025-09-05 07:41:35.909707727 +0000 UTC m=+0.283979824 container init 7dd46d78c7ad9ddcbce3332334abfed9a8eb6275708a9927df2839fd871bb9da (image=quay.io/sustainable_computing_io/kepler:v0.10.2, name> Sep 05 13:11:35 compute-0 podman[222916]: 2025-09-05 07:41:35.941797526 +0000 UTC m=+0.316069613 container start 7dd46d78c7ad9ddcbce3332334abfed9a8eb6275708a9927df2839fd871bb9da (image=quay.io/sustainable_computing_io/kepler:v0.10.2, nam> Sep 05 13:11:35 compute-0 kepler[222933]: kepler: error: unknown short flag '-v', try --help Sep 05 13:11:35 compute-0 podman[222916]: kepler

triggered by openstack-k8s-operators/openstack-operator#1579

@karelyatin
Copy link
Contributor Author

karelyatin commented Sep 8, 2025

Unrelated:- Sep 05 13:11:35 compute-0 systemd[1]: Starting kepler container... Sep 05 13:11:35 compute-0 podman[222916]: 2025-09-05 07:41:35.909707727 +0000 UTC m=+0.283979824 container init 7dd46d78c7ad9ddcbce3332334abfed9a8eb6275708a9927df2839fd871bb9da (image=quay.io/sustainable_computing_io/kepler:v0.10.2, name> Sep 05 13:11:35 compute-0 podman[222916]: 2025-09-05 07:41:35.941797526 +0000 UTC m=+0.316069613 container start 7dd46d78c7ad9ddcbce3332334abfed9a8eb6275708a9927df2839fd871bb9da (image=quay.io/sustainable_computing_io/kepler:v0.10.2, nam> Sep 05 13:11:35 compute-0 kepler[222933]: kepler: error: unknown short flag '-v', try --help Sep 05 13:11:35 compute-0 podman[222916]: kepler

triggered by openstack-k8s-operators/openstack-operator#1579

Needs openstack-k8s-operators/edpm-ansible#1010

@karelyatin
Copy link
Contributor Author

karelyatin commented Sep 8, 2025

recheck revert merged

abays
abays approved these changes Sep 8, 2025
View reviewed changes
Copy link
Contributor

@abays abays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 8, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Sep 8, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abays, karelyatin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 8, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 34a9f04 into openstack-k8s-operators:main Sep 8, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abays abays abays approved these changes

@jlarriba jlarriba Awaiting requested review from jlarriba

@paramite paramite Awaiting requested review from paramite

Assignees

@abays abays

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@karelyatin @abays